Add hostname to DHCPv4 and to the GRPC interface #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guvenc
force-pushed
the
feature/dhcp_host_name
branch
4 times, most recently
from
5d2e417 to
69f1644
Compare
Signed-off-by: Guvenc Gulce <[email protected]>
Signed-off-by: Guvenc Gulce <[email protected]>
guvenc
force-pushed
the
feature/dhcp_host_name
branch
from
69f1644 to
897aaad
Compare
PlagueCZ
requested changes
Apr 8, 2025
Contributor
PlagueCZ
left a comment
PlagueCZ
left a comment
There was a problem hiding this comment.
Looks good, just some polishing details really.
guvenc
force-pushed
the
feature/dhcp_host_name
branch
from
d64f6a9 to
7576e46
Compare
Signed-off-by: Guvenc Gulce <[email protected]>
guvenc
force-pushed
the
feature/dhcp_host_name
branch
from
4e65154 to
ab366fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hostname to DHCPv4 and to the GRPC interface